5.3 compat#562
Merged
Merged
Conversation
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
Member
Author
|
Tests were passing in 1354be4 before I moved the file, so I think vsi_common main is being cloned by a integration test, and will fail until after this is merged in. So ignore the test failures. |
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
scott-vsi
reviewed
May 29, 2026
andyneff
commented
May 29, 2026
Co-authored-by: Andy Neff <andyneff@users.noreply.github.com>
Co-authored-by: scott-vsi <scott.richardson@visionsystemsinc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few changes in bash 5.3 that lead to incompatibilities and failures in VSI Common.
The primary different is
pushd ""+popdno longer silently works exactly as intended. So many patches had to be added for that.